Skip to content

Commit

Permalink
Merge branch 'master' into CMR-10026
Browse files Browse the repository at this point in the history
  • Loading branch information
jmaeng72 authored Aug 7, 2024
2 parents 7872ca4 + cdd8571 commit 342a272
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,16 @@ List impacted areas.

# Checklist

- [ ] I have updated/added unit and integration tests that prove my fix is effective or that my feature works
- [ ] New and existing unit and int tests pass locally and remotely with my changes
- [ ] I have updated/added unit and int tests that prove my fix is effective or that my feature works
- [ ] New and existing unit and int tests pass locally and remotely
- [ ] clj-kondo has been run locally and all errors corrected
- [ ] I have removed unnecessary/dead code and imports in files I have changed
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have cleaned up integration tests by doing one or more of the following:
- migrated any are2 tests to are3 in files I have changed
- de-duped, consolidated, removed dead int tests
- transformed applicable int tests into unit tests
- refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each
2 changes: 2 additions & 0 deletions dev-system/support/run-kondo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ projects_to_check='access-control-app/src \
common-lib/src \
elastic-utils-lib/src \
es-spatial-plugin/src \
indexer-app/src \
ingest-app/src \
message-queue-lib/src \
umm-lib/src'

Expand Down

0 comments on commit 342a272

Please sign in to comment.