Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-9266 refactors permission acl filtering #1926

Merged
merged 2 commits into from
Jul 13, 2023
Merged

CMR-9266 refactors permission acl filtering #1926

merged 2 commits into from
Jul 13, 2023

Conversation

daniel-zamora
Copy link
Contributor

Small improvements to get-permissions code.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2023

Codecov Report

Merging #1926 (c651fca) into master (d9b4b73) will decrease coverage by 0.04%.
The diff coverage is 5.17%.

@@            Coverage Diff             @@
##           master    #1926      +/-   ##
==========================================
- Coverage   55.84%   55.80%   -0.04%     
==========================================
  Files         991      991              
  Lines       62496    62530      +34     
  Branches     1518     1521       +3     
==========================================
- Hits        34899    34896       -3     
- Misses      26079    26113      +34     
- Partials     1518     1521       +3     
Impacted Files Coverage Δ
.../src/cmr/elastic_utils/embedded_elastic_server.clj 12.12% <0.00%> (-0.19%) ⬇️
umm-spec-lib/src/cmr/umm_spec/acl_matchers.clj 65.51% <0.00%> (-2.96%) ⬇️
...pp/src/cmr/access_control/services/acl_service.clj 12.29% <4.34%> (-1.59%) ⬇️
...-lib/src/cmr/redis_utils/embedded_redis_server.clj 87.50% <100.00%> (ø)

... and 3 files with indirect coverage changes

@daniel-zamora daniel-zamora merged commit d04ca7d into master Jul 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants