Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmr 9264 - adding InstanceInformation to UMM-Var for version 1.9. #1928

Merged
merged 6 commits into from
Jul 12, 2023
Merged

Cmr 9264 - adding InstanceInformation to UMM-Var for version 1.9. #1928

merged 6 commits into from
Jul 12, 2023

Conversation

eereiter
Copy link
Contributor

@eereiter eereiter commented Jul 6, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023 •
edited
Loading

Codecov Report

Merging #1928 (1a8fd3d) into master (5e81e5b) will increase coverage by 0.00%.
The diff coverage is 84.61%.

@@           Coverage Diff           @@
##           master    #1928   +/-   ##
=======================================
  Coverage   55.77%   55.77%           
=======================================
  Files         991      991           
  Lines       62602    62613   +11     
  Branches     1531     1530    -1     
=======================================
+ Hits        34917    34924    +7     
- Misses      26158    26159    +1     
- Partials     1527     1530    +3
Impacted Files Coverage Δ
...ib/src/cmr/umm_spec/models/umm_variable_models.clj 51.61% <50.00%> (-0.24%) ⬇️
ingest-app/src/cmr/ingest/config.clj 35.61% <100.00%> (ø)
...ib/src/cmr/umm_spec/migration/version/variable.clj 94.15% <100.00%> (+0.27%) ⬆️
umm-spec-lib/src/cmr/umm_spec/versioning.clj 85.18% <100.00%> (ø)

... and 2 files with indirect coverage changes

jceaser
jceaser approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@jceaser jceaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve pending a review of my comments. My remaining comments just need an assessment and either rejected or adopted as author sees fit.

eudoroolivares2016
eudoroolivares2016 reviewed Jul 10, 2023
View reviewed changes
umm-spec-lib/src/cmr/umm_spec/migration/version/variable.clj Outdated
;; Update the MetadataSpecification and remove InstanceInformation
(-> umm-v
(dissoc :InstanceInformation)
(m-spec/update-version :variable "1.8.2")))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding newline

@eereiter eereiter merged commit 9b08eb7 into master Jul 12, 2023
1 check passed
@eereiter eereiter deleted the CMR-9264 branch August 17, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jceaser jceaser jceaser approved these changes

@eudoroolivares2016 eudoroolivares2016 eudoroolivares2016 approved these changes

@zimzoom zimzoom Awaiting requested review from zimzoom

@dpesall dpesall Awaiting requested review from dpesall

@sxu123 sxu123 Awaiting requested review from sxu123

@jaybarra jaybarra Awaiting requested review from jaybarra

@daniel-zamora daniel-zamora Awaiting requested review from daniel-zamora

@isja17 isja17 Awaiting requested review from isja17

@TylerHeald1 TylerHeald1 Awaiting requested review from TylerHeald1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eereiter @codecov-commenter @jceaser @eudoroolivares2016