Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10023: Part 1 #2151

Merged
merged 7 commits into from
Aug 5, 2024
Merged

CMR-10023: Part 1 #2151

merged 7 commits into from
Aug 5, 2024

Conversation

jmaeng72
Copy link
Contributor

@jmaeng72 jmaeng72 commented Jul 24, 2024

Overview

What is the feature/fix?

Change logs from info to debug for search api and data folders

What is the Solution?

Switch logs from info to debug for logs that are already repeated in the REPORT log

What areas of the application does this impact?

Search App logs

Checklist

  • I have updated/added unit and integration tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely with my changes
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 58.10%. Comparing base (f5af38e) to head (ca0ecc5).

Files Patch % Lines
.../search/data/metadata_retrieval/metadata_cache.clj 0.00% 7 Missing ⚠️
search-app/src/cmr/search/api/tags.clj 0.00% 4 Missing ⚠️
search-app/src/cmr/search/api/concepts_lookup.clj 0.00% 2 Missing ⚠️
search-app/src/cmr/search/api/concepts_search.clj 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2151      +/-   ##
==========================================
- Coverage   58.11%   58.10%   -0.01%     
==========================================
  Files        1044     1044              
  Lines       70321    70323       +2     
  Branches     2006     2008       +2     
==========================================
- Hits        40867    40863       -4     
- Misses      27582    27586       +4     
- Partials     1872     1874       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmaeng72 jmaeng72 merged commit 14fd29b into master Aug 5, 2024
6 checks passed
@jmaeng72 jmaeng72 deleted the CMR-10023-1 branch August 5, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants