Feature CMR-10024 : Less Timed Logs from Ingest

[jceaser]

Overview

Remove large quantities of logs which are not helpful.

What is the feature/fix?

1. Removing defn-timed calls for functions which are either fast enough to not worry about, infrequent, or fast and frequent but inside another defn-timed.

2. Added a new macro, defn-timed-level which allows code to specify the log level to send timed info to. Using this for one log.

What is the Solution?

removing defn-timed macro from function definition.

What areas of the application does this impact?

Most changes are in ingest, one change is in common.

I have also run clj-kondo on ingest and made significant changes.

Checklist

• [-] I have updated/added unit and integration tests that prove my fix is effective or that my feature works
• New and existing unit and int tests pass locally and remotely with my changes
• I have removed unnecessary/dead code and imports in files I have changed
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• [-] I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have cleaned up integration tests by doing one or more of the following:
  • de-duped, consolidated, removed dead int tests
  • transformed applicable int tests into unit tests
  • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

[jceaser]

I do have an open question about the macro defn-timed-level. I wonder if there is a more graceful way of doing this macro by maybe reusing the code in defn-timed instead of just making a copy. Or I could deprecate defn-timed and migrate everything oven to the new function (in the future). Any thoughts?