-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmr 9848 association status #2174
Open
sxu123
wants to merge
22
commits into
master
Choose a base branch
from
CMR-9848-Association-Status
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2174 +/- ##
==========================================
- Coverage 58.15% 58.14% -0.01%
==========================================
Files 1045 1045
Lines 70428 70430 +2
Branches 2000 1998 -2
==========================================
- Hits 40959 40954 -5
- Misses 27610 27612 +2
- Partials 1859 1864 +5 ☔ View full report in Codecov by Sentry. |
eereiter
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature/fix?
Return proper status when processing association requests.
What is the Solution?
When processing association request, only return 400 status when ALL associations fail, rather than when ANY association fails. This includes all generic associations and regular associations, except for tag association. When I changed tag associations return status from 400 to 200 with only partial failure, for some mysterious reason, some ACL related stuff failed in the build, which I really don't see any connection with the fix. I'm writing a separate ticket for the tag association part since I don't have time to fix it.
What areas of the application does this impact?
CMR search.
Checklist