Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10121 As a user I want to see entry-id (EntryId) in the UMM and/or JSON response. #2178

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

daniel-zamora
Copy link
Contributor

@daniel-zamora daniel-zamora commented Sep 30, 2024

Overview

What is the feature/fix?

Adds entry-id to atom and json collection search response.

What is the Solution?

Adds entry-id to atom and json collection search response. Updates test utils.

What areas of the application does this impact?

List impacted areas.

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@daniel-zamora daniel-zamora marked this pull request as draft September 30, 2024 21:48
@daniel-zamora
Copy link
Contributor Author

daniel-zamora commented Sep 30, 2024

converted to draft so I can address all the checkboxes

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.17%. Comparing base (53f7115) to head (b9ebc8e).

Files with missing lines Patch % Lines
...r/search/results_handlers/atom_results_handler.clj 0.00% 2 Missing ⚠️
...rch/results_handlers/atom_json_results_handler.clj 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2178      +/-   ##
==========================================
- Coverage   58.18%   58.17%   -0.01%     
==========================================
  Files        1047     1047              
  Lines       70480    70486       +6     
  Branches     2004     1999       -5     
==========================================
  Hits        41008    41008              
- Misses      27608    27613       +5     
- Partials     1864     1865       +1     
Flag Coverage Δ
58.18% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniel-zamora daniel-zamora changed the title Cmr 10121 CMR-10121 As a user I want to see entry-id (EntryId) in the UMM and/or JSON response. Oct 1, 2024
@daniel-zamora daniel-zamora marked this pull request as ready for review October 1, 2024 00:22
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@daniel-zamora daniel-zamora merged commit 206bf56 into master Oct 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants