Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HARMONY-1781 - Update to harmony-service-lib-py==2.0.0. #10

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

owenlittlejohns
Copy link
Member

@owenlittlejohns owenlittlejohns commented Sep 30, 2024

Description

This PR updates most of the dependencies for this service. Most notably, the harmony-service-lib-py dependency is bumped to v2.0.0. This is a breaking change for that package, as it repackages the functionality under a namespace of harmony_service_lib instead of harmony. (See here for more information).

A couple of other quick notes:

  • I updated the other dependencies where I could, because that's a good practice. I couldn't bump numpy because of the requirements of earthdata-varinfo. (That could/should be improved in the future)
  • I've put a couple of PRs up against this service to help the Harmony team test changes to harmony-service-lib-py. The main reason for choosing this service is that it doesn't have much development going on it it, and it's a pretty lean service to update.

Jira Issue ID

HARMONY-1781

Local Test Steps

  • Pull this branch.
  • Build the service image, test image and run the tests locally. ./bin/build-image && ./bin/build-test && ./bin/run-test
  • Start a local Harmony instance that includes the regridding service (having harmony-regridder in the LOCALLY_DEPLOYED_SERVICES variable in .env)
  • Run the Harmony Regridding Service regression test suite against your local Harmony instance - although note, I was having issues where my local instance could not download the EEDTEST collection files hosted in the Harmony UAT AWS account. I think those issues are unrelated to this change (and indeed the path of the function trying to do the download included harmony_service_lib, which is a good sign).

PR Acceptance Checklist

  • Jira ticket acceptance criteria met. - Validation of HARMONY-1781
  • CHANGELOG.md updated to include high level summary of PR changes.
  • docker/service_version.txt updated if publishing a release.
  • Tests added/updated and passing.
  • Documentation updated (if needed).

Copy link
Member

@flamingbear flamingbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Tested everything and looks as expected.

@owenlittlejohns owenlittlejohns merged commit 61f1276 into main Oct 1, 2024
4 checks passed
@owenlittlejohns owenlittlejohns deleted the HARMONY-1781-harmony-service-lib-rename branch October 1, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants