Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-558 - Update service to use earthdata-varinfo==3.0.0. #7

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

owenlittlejohns
Copy link
Member

Description

This PR updates the Harmony Regridding Service to use earthdata-varinfo==3.0.0, which entails a significant update to the configuration file schema. The bulk of this PR is just amending the specific configuration file instance that the Harmony Regridding Service uses to:

  • Remove extraneous underscores.
  • Remove an unused section of the configuration file (ProductEpochs).
  • Rename CF_Overrides to MetadataOverrides and flatten the Applicability.

Jira Issue ID

TRT-558

Local Test Steps

  • Pull this branch.
  • Run the unit tests locally: ./bin/build-image && ./bin/build-test && ./bin/run-test
  • Build the image (./bin/build-image), then re-bootstrap a local Harmony instance to include harmony-regridder in the LOCALLY_DEPLOYED_SERVICES environment variable in the Harmony .env.
  • Run the regression test suite against your local Harmony in a Box instance. To run it locally, you'll need to create a conda environment and run a local Jupyter notebook server.

PR Acceptance Checklist

  • Jira ticket acceptance criteria met.
  • CHANGELOG.md updated to include high level summary of PR changes.
  • docker/service_version.txt updated if publishing a release.
  • Tests added/updated and passing.
  • Documentation updated (if needed).

[v1.0.0]: https://github.com/nasa/harmony-regridding-service/compare/0.0.4-legacy..1.0.0
[v1.0.2]: https://github.com/nasa/harmony-regridding-service/releases/tag/1.0.2
[v1.0.1]: https://github.com/nasa/harmony-regridding-service/releases/tag/1.0.1
[v1.0.0]: https://github.com/nasa/harmony-regridding-service/releases/tag/1.0.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flamingbear - I think this is the transition you made in one of the recent change logs. Let me know if this is the preferred URL format you like, or if I should update to something else.

Copy link
Member

@flamingbear flamingbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great. I dig the new schema, it's so much easier to understand. :shipit:

@owenlittlejohns owenlittlejohns merged commit 4ebff36 into main Sep 23, 2024
4 checks passed
@owenlittlejohns owenlittlejohns deleted the TRT-558-migrate-earthdata-varinfo-3.0.0 branch September 23, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants