Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HARMONY-1908 - Update to harmony-service-lib-py==1.1.0. #9

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

owenlittlejohns
Copy link
Member

@owenlittlejohns owenlittlejohns commented Sep 26, 2024

Description

This PR is a validation of the new pyproject.toml-based packaging used in harmony-service-lib-py (see this PR). There are no functional differences to the regridding service.

Jira Issue ID

HARMONY-1908

Local Test Steps

  • Pull this branch and run the unit tests (./bin/buid-image && ./bin/build-test && ./bin/run-test). The service should build and the tests should all pass.
  • Bonus: Stand up a local Harmony instance, start a local Jupyter notebook server and run the Harmony regression tests for this service against that local Harmony service.

PR Acceptance Checklist

  • Jira ticket acceptance criteria met.
  • CHANGELOG.md updated to include high level summary of PR changes.
  • docker/service_version.txt updated if publishing a release.
  • Tests added/updated and passing. (No functional changes to the service)
  • Documentation updated (if needed). (No changes required to documentation)

@owenlittlejohns
Copy link
Member Author

owenlittlejohns commented Sep 26, 2024

@chris-durbin - just FYI.

Copy link
Member

@flamingbear flamingbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, so do the regressions. Looks good

@owenlittlejohns owenlittlejohns merged commit e5f45f5 into main Sep 26, 2024
4 checks passed
@owenlittlejohns owenlittlejohns deleted the HARMONY-1908-check-packaging branch September 26, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants