Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 167 pass ruff linting checks #168

Merged
merged 14 commits into from
Mar 12, 2024

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Mar 12, 2024

GitHub Issue: #167

Description

This change addresses a failing lint check, and avoids warnings from ruff

Local test steps

Ran and passed the test suite.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • [N/A] Integration testing
  • CHANGELOG.md updated
  • [N/A] Documentation updated (if needed).

📚 Documentation preview 📚: https://ncompare--168.org.readthedocs.build/en/168/

ncompare bot and others added 14 commits February 6, 2024 18:06
Following "warning: `ruff <path>` is deprecated. Use `ruff check <path>` instead."
Following: "warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'"
@danielfromearth danielfromearth merged commit 82cf136 into develop Mar 12, 2024
8 checks passed
@danielfromearth danielfromearth deleted the feature/issue-167-pass-ruff-linting-checks branch March 12, 2024 18:59
@danielfromearth danielfromearth mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant