Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 198 resolve linting error #199

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Apr 30, 2024

GitHub Issue: #198

Description

This change resolves the ruff linting error, UP031.

Local test steps

Ran ruff locally, and it passed.

PR Acceptance Checklist

  • [n/a] Unit tests added/updated and passing.
  • [n/a] Integration testing
  • CHANGELOG.md updated
  • [n/a] Documentation updated (if needed).

📚 Documentation preview 📚: https://ncompare--199.org.readthedocs.build/en/199/

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.95%. Comparing base (3efabc5) to head (01fc7bc).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #199   +/-   ##
========================================
  Coverage    89.95%   89.95%           
========================================
  Files            5        5           
  Lines          468      468           
========================================
  Hits           421      421           
  Misses          47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth self-assigned this Apr 30, 2024
@danielfromearth danielfromearth added the bug Something isn't working label Apr 30, 2024
@danielfromearth danielfromearth linked an issue Apr 30, 2024 that may be closed by this pull request
@danielfromearth danielfromearth merged commit 21d21f1 into develop Apr 30, 2024
10 checks passed
@danielfromearth danielfromearth deleted the feature/issue-198-resolve-linting-error branch April 30, 2024 14:46
@danielfromearth danielfromearth mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve linting error
1 participant