-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relax upper bound constraints of dependencies #236
relax upper bound constraints of dependencies #236
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #236 +/- ##
========================================
Coverage 90.92% 90.92%
========================================
Files 5 5
Lines 463 463
========================================
Hits 421 421
Misses 42 42 ☔ View full report in Codecov by Sentry. |
@jhkennedy, how does this change look to you (for addressing the issue of upper bounds on dependencies)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly! Does xarray need the upper bound as well? For the upper bounds especially, the idea is they should communicate "this is a known or expected incompatibility"
I'm not sure why |
GitHub Issue: #231
Description
This change removes the upper bound constraints on dependency versions in
pyproject.toml
.Overview of integration done
Passed CI tests.
PR Acceptance Checklist
CHANGELOG.md
updated📚 Documentation preview 📚: https://ncompare--236.org.readthedocs.build/en/236/