Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax upper bound constraints of dependencies #236

Merged

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Jun 17, 2024

GitHub Issue: #231

Description

This change removes the upper bound constraints on dependency versions in pyproject.toml.

Overview of integration done

Passed CI tests.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://ncompare--236.org.readthedocs.build/en/236/

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (f78e124) to head (6b41c0a).
Report is 41 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #236   +/-   ##
========================================
  Coverage    90.92%   90.92%           
========================================
  Files            5        5           
  Lines          463      463           
========================================
  Hits           421      421           
  Misses          42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth
Copy link
Collaborator Author

@jhkennedy, how does this change look to you (for addressing the issue of upper bounds on dependencies)?

Copy link

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly! Does xarray need the upper bound as well? For the upper bounds especially, the idea is they should communicate "this is a known or expected incompatibility"

@danielfromearth
Copy link
Collaborator Author

danielfromearth commented Jun 25, 2024

Yes, exactly! Does xarray need the upper bound as well? For the upper bounds especially, the idea is they should communicate "this is a known or expected incompatibility"

I'm not sure why xarray didn't get updated when I ran poetry relax. Will manually check and update that one too.

@danielfromearth danielfromearth self-assigned this Jul 5, 2024
@danielfromearth danielfromearth added the dependencies Pull requests that update a dependency file label Jul 5, 2024
@danielfromearth danielfromearth merged commit e48860f into develop Jul 5, 2024
10 checks passed
@danielfromearth danielfromearth deleted the feature/issue-231-remove-upper-bounds-from-deps branch July 5, 2024 20:30
@danielfromearth danielfromearth linked an issue Jul 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conders removing upper bounds from dependencies
2 participants