Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecation of xarray Dataset.dims #247

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

nannau
Copy link

@nannau nannau commented Jul 9, 2024

GitHub Issue: #246

Description

Update core.py to reflect xarray Dataset.dims deprecation in favour of Dataset.sizes.

Local test steps

Ran without any arguments comparing two identical file copies (taken from https://www.unidata.ucar.edu/software/netcdf/examples/files.html). The proposed changes resolves the FutureWarning.

ncompare file1.nc file2.nc

Overview of integration done

I couldn't find docs for this in contributing so I'm assuming this is referencing an internal process.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://ncompare--247.org.readthedocs.build/en/247/

@danielfromearth danielfromearth changed the base branch from main to develop July 10, 2024 13:41
@danielfromearth danielfromearth changed the base branch from develop to feature/xarray_dims_to_sizes July 10, 2024 13:46
@danielfromearth
Copy link
Collaborator

Thanks for contributing this fix, @nannau! I'm changing the base branch so we can run the integration tests, and then get it merged!

@danielfromearth danielfromearth linked an issue Jul 10, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (21f43db) to head (a1aab98).

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/xarray_dims_to_sizes     #247   +/-   ##
=============================================================
  Coverage                         90.92%   90.92%           
=============================================================
  Files                                 5        5           
  Lines                               463      463           
=============================================================
  Hits                                421      421           
  Misses                               42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth changed the base branch from feature/xarray_dims_to_sizes to develop July 10, 2024 13:55
@danielfromearth danielfromearth merged commit 3d19973 into nasa:develop Jul 10, 2024
9 checks passed
@nannau
Copy link
Author

nannau commented Jul 10, 2024

Thanks for contributing this fix, @nannau! I'm changing the base branch so we can run the integration tests, and then get it merged!

Cheers, @danielfromearth!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xarray Dataset.dims FutureWarning
2 participants