This repository has been archived by the owner on Apr 15, 2023. It is now read-only.
fix: Remove deletion of __v when creating history doc #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkeaton
commented
Oct 14, 2020
| @@ -113,12 +113,12 @@ module.exports = function historyPlugin(schema, options) { | |||
| }); | |||
|
|
|||
| function createHistoryDoc(d, operation) { | |||
| d.__v = undefined; | |||
| const { __v, ...doc } = d; | |||
There was a problem hiding this comment.
Instead of setting __v to undefined I'm using the object spread operator to copy all of the other fields into a variable called doc which I'm then setting on the history document.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting __v to undefined causes the main document to be saved with a version key of
nullin some cases.This fix addresses the following issues:
#58
#45