standardize taskgraph cache name and location for all models #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlys
commented
Aug 23, 2023
HISTORY.rst
Outdated
| all models. It is now called ``taskgraph_cache`` and located in the top | ||
| level of the workspace directory. | ||
| (`#1230 <https://github.com/natcap/invest/issues/1230>`_) | ||
| * Coastal Blue Carbon |
There was a problem hiding this comment.
Not sure why this is showing up in the diff - it was already in main.
dcdenu4
reviewed
Aug 25, 2023
|
|
||
| suffix = utils.make_suffix_string(args, 'results_suffix') | ||
| intermediate_dir = os.path.join( | ||
| args['workspace_dir'], INTERMEDIATE_DIR_NAME) | ||
| output_dir = os.path.join( | ||
| args['workspace_dir'], OUTPUT_DIR_NAME) | ||
|
|
||
| utils.make_directories([output_dir, intermediate_dir, taskgraph_cache_dir]) | ||
| utils.make_directories([output_dir, intermediate_dir]) |
There was a problem hiding this comment.
TaskGraph creates the taskgraph cache dir if it doesn't exist already, right?
Comment on lines
-447
to
-449
| 'outflow_direction_path': 'outflow_direction.tif', | ||
| 'outflow_weights_path': 'outflow_weights.tif', | ||
| 'kc_path': 'kc.tif', |
There was a problem hiding this comment.
Were these deletions not being used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1230
I went with
taskgraph_cachefor the name of the directory. I put it at the top level in the workspace because not all models have an intermediate directory.A few models used a cache directory that contained the
taskgraph.dbfile as well as some other less-important intermediate outputs. I split these up so the taskgraph cache has its own directory and the intermediate outputs go in theintermediatedirectory.Added output specs for SWY cache outputs that were missing them.
Checklist