REC: point_nearest_distance metric now measures from centroid
#1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt-nearest-distance
davemfish
commented
Aug 25, 2023
| @@ -581,14 +581,14 @@ def test_all_metrics_local_server(self): | |||
| expected_grid_vector_path = os.path.join( | |||
| REGRESSION_DATA, 'predictor_data_all_metrics.shp') | |||
| utils._assert_vectors_equal( | |||
| out_grid_vector_path, expected_grid_vector_path, 1e-3) | |||
| expected_grid_vector_path, out_grid_vector_path, 1e-3) | |||
There was a problem hiding this comment.
When it fails, the message from this assertion function expects the first arg to be the "expected" value and second to be the "actual".
dcdenu4
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The User's Guide (i.e. model spec) suggested it was measuring from "center" of an AOI polygon to the predictor point, whereas it was actually measuring from the edge of the polygon. Now it measures from the centroid.
Fixes #1347
Checklist