Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the location of the electron logfiles from the logger itself #1454

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

davemfish
Copy link
Contributor

Instead of assuming we know where the logfiles are, ask the logger.
Fixes #1452

There's also some additional logging here on the exit of an invest subprocess.

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@davemfish davemfish requested a review from emlys November 17, 2023 17:24
@davemfish davemfish self-assigned this Nov 17, 2023
Copy link
Member

@emlys emlys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @davemfish! I tested this on my mac and it works for me.

@emlys emlys merged commit 9ecd48c into natcap:main Dec 1, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workbench: "Find my logs" button does not work on MacOS
2 participants