Clarify threat table column about section in model spec. #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlys
reviewed
Nov 27, 2023
src/natcap/invest/habitat_quality.py
Outdated
| "Map of the threat's distribution in the current " | ||
| "scenario. Each pixel value is the relative intensity " | ||
| "of the threat at that location. ") | ||
| "File system path to a raster of the threat's " |
There was a problem hiding this comment.
I would suggest leaving out the "File system" from each of these. Users may not know what a file system is, and it might just confuse them.
emlys
reviewed
Nov 27, 2023
emlys
reviewed
Nov 27, 2023
emlys
reviewed
Nov 27, 2023
Co-authored-by: Emily Soth <[email protected]>
Co-authored-by: Emily Soth <[email protected]>
Co-authored-by: Emily Soth <[email protected]>
|
Thanks @emlys, I swapped "File system path" out with just "Path". Good suggestion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per @newtpatrol recommendation, updating the about section for the
[cur|fut|base]_pathcolumns in the threats table to clarify that we are indeed looking for file system path strings.Fixes #1455
Checklist