Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stick to node version 18 in build environments #1471

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

davemfish
Copy link
Contributor

GHA was getting a bit ahead of us by building in a node v20, environment. I haven't tried that yet, and created a separate issue to deal with all the package upgrades that might go along with that.

Fixes #1465

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@davemfish davemfish self-assigned this Dec 12, 2023
@davemfish davemfish added this to the 3.14.1 milestone Dec 12, 2023
@davemfish davemfish added the critical for issues likely to obstruct the whole dev team (e.g. broken builds) label Dec 12, 2023
Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dcdenu4 dcdenu4 merged commit 8f8db4e into natcap:main Dec 12, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical for issues likely to obstruct the whole dev team (e.g. broken builds)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHA failures due to node version conflicts
2 participants