Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sample data commit hash #1568

Merged
merged 1 commit into from
May 8, 2024

Conversation

emlys
Copy link
Member

@emlys emlys commented May 8, 2024

Description

For the last CBC PR, I increased the analysis year in the sample data, but I forgot to also extend the price table through that new year, which caused the binary tests to fail on main. Didn't catch it earlier because we don't run invest-autotest on PRs. Here I'm updating the sample data again to correct that.

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@emlys emlys marked this pull request as ready for review May 8, 2024 22:33
@emlys emlys requested a review from phargogh May 8, 2024 22:33
@emlys emlys self-assigned this May 8, 2024
Copy link
Member

@phargogh phargogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great, thanks for catching that!

@phargogh phargogh merged commit 239108b into natcap:main May 8, 2024
29 checks passed
@emlys emlys deleted the bugfix/cbc-sampledata-version branch October 3, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants