Distribute mamba with workbench #1604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regular expression for env match. Add flag to quiet Windows cmd pop ups
dcdenu4
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Thanks @emlys and sorry for being so slow. I had a few comments and questions but nothing major.
You mentioned commenting out the puppeteer test, I don't see that in here. Was that testing pulled out of this PR or handled elsewhere?
| * @returns {string} mamba executable. | ||
| */ | ||
| export function findMambaExecutable(isDevMode) { | ||
| // Binding to the invest server binary: |
Comment on lines
+67
to
+68
| const ext = (process.platform === 'win32') ? '.exe' : ''; | ||
| const filename = `invest${ext}`; |
There was a problem hiding this comment.
It looks like these are leftover and not used.
Comment on lines
81
to
+83
| const investExe = findInvestBinaries(ELECTRON_DEV_MODE); | ||
| settingsStore.set('investExe', investExe); | ||
| settingsStore.set('mamba', findMambaExecutable(ELECTRON_DEV_MODE)); |
There was a problem hiding this comment.
This is nitpicky but do we want to be consistent with whether we create a variable for a returned binary path or just call it from within the function signature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to merge the mamba distribution work into the plugins feature branch.
Commented out the puppeteer test for plugins because it kept timing out on Github Actions; to be addressed in a separate issue (#1621)
Description
Fixes #
Checklist