Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbench Form Validation UI Updates #1614

Merged

Conversation

emilyanndavis
Copy link
Contributor

@emilyanndavis emilyanndavis commented Aug 15, 2024

Description

Fixes #912.

Specifically:

  • Updates permission error messages to distinguish between a directory vs. a file and include verbose permission type (e.g., "You must have write access to this directory" instead of "You must have w access to this file")
  • Removes input type (directory, raster, csv, etc.) from error message UI and adds it to the corresponding label instead, to ensure this helpful info persists in the UI regardless of interaction state
  • Adds aria-describedby to input fields to associate them with their error messages (for screen reader support)
  • Adds custom styling to <select> (dropdown) form fields—including green border when valid—for more consistency with appearance of other form fields
  • Top-aligns labels to prevent vertical shift when an error message appears
  • Aligns start of error message with the left edge of its form field (instead of with the info button)

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • [n/a] Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

Representative screenshots

workbench-form-validation-ui_2024-08-15

@emilyanndavis emilyanndavis marked this pull request as ready for review August 15, 2024 23:59
Copy link
Contributor

@davemfish davemfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @emilyanndavis , this is all very thorough and clear! These will be nice enhancements to the UI.

@davemfish davemfish merged commit f18b211 into natcap:main Aug 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minor improvements to arg form validation UI
2 participants