Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: saving datastack with absolute paths #1628

Conversation

emilyanndavis
Copy link
Contributor

Description

Fixes #1609 by resetting relativePaths to false each time the modal opens.

Confirmed this works by saving a datastack with Relative Paths checked (paths are indeed relative), then, in the same tab, saving the datastack with Relative Paths left unchecked (paths are indeed absolute).

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
    - [ ] Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

Copy link
Contributor

@davemfish davemfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@davemfish davemfish merged commit 3c1221e into natcap:main Sep 12, 2024
29 checks passed
@emilyanndavis emilyanndavis deleted the bugfix/1609-workbench-save-datastack-abs-paths branch September 12, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workbench: Saving datastack with absoluate paths uses relative paths anyway
2 participants