Merge pull request #109 from nathanielvarona/automation-reachability-…

…test-default-ping-count Reachability Test Default Ping Count
nathanielvarona · Oct 24, 2023 · 769c1e3 · 769c1e3
2 parents 35ca9cd + b8235bc
commit 769c1e3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/connection-tests-basic.yml b/.github/workflows/connection-tests-basic.yml
@@ -59,10 +59,11 @@ jobs:
         run: |
           # VPN Gateway Reachability Test
 
+          ping_count_number=5
           profile_ip=$(pritunl-client list -j | jq ". | sort_by(.name)" | jq ".[0]" | jq -r ".client_address")
 
           vpn_gateway="$(ipcalc $profile_ip | awk 'NR==6{print $2}')"
-          ping_flags="$([[ "$RUNNER_OS" == "Windows" ]] && echo "-n 10" || echo "-c 10")"
+          ping_flags="$([[ "$RUNNER_OS" == "Windows" ]] && echo "-n $ping_count_number" || echo "-c $ping_count_number")"
 
           # Ping VPN Gateway
           ping $vpn_gateway $ping_flags
diff --git a/README.md b/README.md
@@ -234,9 +234,11 @@ You can use the full profile name as well, it is also acceptable.
     echo "ipcalc version $(ipcalc --version)"
 
     # VPN Gateway Reachability Test
+    ping_count_number=5
     profile_ip=$(pritunl-client list -j | jq -r 'sort_by(.name) | .[0].client_address')
+
     vpn_gateway="$(ipcalc $profile_ip | awk 'NR==6{print $2}')"
-    ping_flags="$([[ "$RUNNER_OS" == "Windows" ]] && echo "-n 10" || echo "-c 10")"
+    ping_flags="$([[ "$RUNNER_OS" == "Windows" ]] && echo "-n $ping_count_number" || echo "-c $ping_count_number")"
 
     # Ping VPN Gateway
     ping $vpn_gateway $ping_flags