Skip to content

Commit

Permalink
Emitting "finish" event.
Browse files Browse the repository at this point in the history
  • Loading branch information
nathanpeck committed Sep 26, 2014
1 parent 1da8b24 commit 140c467
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
Changelog
=========

#### 1.0.2 (2014-09-26)

Now emits a "finish" event, as well as the "uploaded" event, in order to adhere to Node.js writable stream spec.

#### 1.0.1 (2014-09-26)

Fixed error in usage in the documentation and examples. The examples did not use the "new" keyword when creating the upload stream, so there were scope issues when doing parallel uploads. This has been clarified and corrected in the documentation and examples.
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ A pipeable write stream which uploads to Amazon S3 using the multipart file uplo

### Changelog

#### 1.0.1 (2014-09-26)
#### 1.0.2 (2014-09-26)

Fixed error in usage in the documentation and examples. The examples did not use the "new" keyword when creating the upload stream, so there were scope issues when doing parallel uploads. This has been clarified and corrected in the documentation and examples.
Now emits a "finish" event, as well as the "uploaded" event, in order to adhere to Node.js writable stream spec.

#### 1.0.0 (2014-09-15)
#### 1.0.1 (2014-09-26)

Major overhaul of the functional interface. Breaks compatability with older versions of the module in favor of a cleaner, more streamlined approach. A migration guide for users of older versions of the module has been included in the documentation.
Fixed error in usage in the documentation and examples. The examples did not use the "new" keyword when creating the upload stream, so there were scope issues when doing parallel uploads. This has been clarified and corrected in the documentation and examples.

[Historical Changelogs](CHANGELOG.md)

Expand Down
2 changes: 1 addition & 1 deletion lib/s3-upload-stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ module.exports = {
else {
// Emit both events for backwards compatability, and to follow the spec.
self.ws.emit('uploaded', result);
self.ws.emit('finished', result);
self.ws.emit('finish', result);
}
}
);
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "s3-upload-stream",
"description": "Writeable stream for uploading content of unknown size to S3 via the multipart API.",
"version": "1.0.1",
"version": "1.0.2",
"author": {
"name": "Nathan Peck",
"email": "[email protected]"
Expand Down

0 comments on commit 140c467

Please sign in to comment.