-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "zoom images" feature #578
Open
charlesbaynham
wants to merge
9
commits into
nathansearles:SlidesJS-3
Choose a base branch
from
charlesbaynham:Zoom-and-Resize
base: SlidesJS-3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add "zoom images" feature #578
charlesbaynham
wants to merge
9
commits into
nathansearles:SlidesJS-3
from
charlesbaynham:Zoom-and-Resize
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 519 was indented with tabs instead of spaces which caused coffee-script to fail.
Adding the “zoom = true” option will cause images to be zoomed & centred in the slider div so that they fill the slider without being distorted
If zoom is set to true, children imgs of div slides will also be expanded in the same way that imgs are
Zooming actually only needs to be done once since the slider preserves its aspect ratio
Allow the slider to be resized using javascript after it’s loaded.
@@ -516,7 +594,7 @@ | |||
# Stop/pause slideshow on mouse enter | |||
slidesContainer.bind "mouseenter", => | |||
clearTimeout @data.restartDelay | |||
$.data this, "restartDelay", null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was from a previous commit. On mac, it was stopping coffee-script from compiling.
…on future load events in case the image src changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option "zoom" to allow users to set their images to resize until they fill the slider. Images will be resized and centered, but not distorted.