Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade iOS Mapbox API to 6.4.1 #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madmas
Copy link
Contributor

@madmas madmas commented Sep 12, 2022

Propose upgrade of the Mapbox SDK to the last version that seems to be compatible with this plugin implemented (see #92 as a follow up).

Currently, the map view crashes within all iOS emulators I had the chance to try it with. After upgrading it to the given version, it works.

the pin to the current version was done in 3aa8196 but I couldn't find any reason for it.

Notice: the demo-ng app will fail to start as currently, it has "@nativescript/ios": "6.5.4" in its dependencies. After upgrading it (to 8.3.3), the demo runs fine.

@madmas
Copy link
Contributor Author

madmas commented Sep 14, 2022

Test on iOS 15.6.1 (iPhone 11 Pro), both demo and an external application, went fine.

@farfromrefug
Copy link
Member

@madmas i am no sure about this.

  • First you should be able to override the pod version from your app Podfile
  • i have not use this plugin in a long time but the reason to stick to 5.x was Mabpox changed the rules which was no good for OSS projects. But i dont remember which rule i have to search again.

Can you confirm it works by forcing in your app podfile?

PS: would be good for someone to take the lead on this plugin. I will start supporting it because of the licensing system of mapbox . I might do a maplibre version at one point but that's it.

@madmas
Copy link
Contributor Author

madmas commented Sep 14, 2022

@farfromrefug thanks a lot for the reply.
I had fogotten about the option to override Pod version (anyone stumbling on this, check out https://blog.nativescript.org/nativescript-6.2-the-darkest-release-ever/#Improved_Conflict_Resolution_of_Pod_files).

Yes, I could successfully validate it´s working that way. So should we mention that option in the README instead of upgrading to the newer version? (I´d rather go for the upgrade)...

I agree, licensing at mapbox is not super-friendly but they are providung a nice product with a great free-tier ;-)
And there are only very few alternatives.

@farfromrefug
Copy link
Member

@madmas yes if you would like to create a PR for the doc that would be awesome.
as for alternatives there are actually quite a lot now and very strong one:

  • Carto Mobile SDK (@nativescript-community/ui-carto) is the strongest one for me. Crazy framework and perfs are simply on another level. Now Carto does not provide good vector tiles hosted data. But you can use any remote hosted vector tiles, even mapbox (though their licensing did change a few month back and they might not allow it anymore).
  • You also have other frameworks like those mention here https://www.geoapify.com/mapbox-gl-new-license-and-6-free-alternatives
  • Maptiler have great hosted solutions . Their map data is awesome and gives you much more control than mapbox does. There are a lot of others vector tiles providers. You could find those with a simple search on the web.

I should mention that today you can very easily host your own vector tiles with products like OpenMapTiles or Planetiler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants