LPS-118184 #761
LPS-118184 #761
Conversation
…w this information in search container so it is more consistent, specially with languages like basque
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
ci:test:sf |
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-118184-b 1 Successful Jobs:For more details click here. |
|
ci:test:relevant |
|
Jenkins Build:test-portal-source-format#3533 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6960 |
|
Just started reviewing :) |
Sent from
|
Pull request submitted to antonio-ortega#130. See changes here. |
There was a problem hiding this comment.
@antonio-ortega, please check my comment below and re-send on top of antonio-ortega#130.
Thanks.
| @@ -185,8 +188,6 @@ protected String getDDMFormFieldValue( | |||
| List<DDMFormInstanceRecord> ddmFormInstanceRecords, Locale locale) | |||
| throws Exception { | |||
|
|
|||
| DateTimeFormatter dateTimeFormatter = getDateTimeFormatter(locale); | |||
There was a problem hiding this comment.
Hey @antonio-ortega, can you please also remove this method and its references on tests? After your fix, it became useless as the method formatDate.
Thanks.
Hi @natocesarrego ,
This is coming from #757, I've removed formatDate method since it is no longer used (and its test) and I've fixed testGetDDMFormFieldValues according to the logic.
Let me know if you have any question.
Thanks.
Regards.