Skip to content

Commit

Permalink
Compact the versioning metadata
Browse files Browse the repository at this point in the history
Also remove some unused information in ADR-43

Signed-off-by: R.I.Pienaar <[email protected]>
  • Loading branch information
ripienaar committed Oct 30, 2024
1 parent 182511d commit b106724
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 20 deletions.
13 changes: 0 additions & 13 deletions adr/ADR-43.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,19 +52,6 @@ The `Nats-Limit-Applied` field is there to support future expansion of this feat

This behaviour is off by default unless opted in on the Stream Configuration.

## Publish Acknowledgements

We could optionally extend the `PubAck` as follows:

```golang
type PubAck struct {
MsgTTL uint64 `json:"msg_ttl,omitempty"`
}
```

This gives clients a chance to confirm, without Stream Info or should the Stream be edited after Info, if the TTL
got applied.

## Stream Configuration

Weather or not a stream support this behavior should be a configuration opt-in. We want clients to definitely know
Expand Down
12 changes: 5 additions & 7 deletions adr/ADR-44.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,11 @@ API level only needs to be incremented once and not for every new feature.
We'll store current server and asset related information in the existing `metadata` field allowing us to expand this in
time, today we propose the following:

| Name | Description |
|----------------------------------|-----------------------------------------------------------|
| `_nats.server.version` | The current server version hosting an asset |
| `_nats.server.api_level` | The current server API level hosting an asset |
| `_nats.server.require.api_level` | The required API level to start an asset |
| `_nats.created.server.version` | The version of the server that first created this asset |
| `_nats.created.server.api_level` | The API level of the server that first created this asset |
| Name | Description |
|-------------------|-----------------------------------------------|
| `_nats.ver` | The current server version hosting an asset |
| `_nats.level` | The current server API level hosting an asset |
| `_nats.req.level` | The required API level to start an asset |

We intend to store some client hints in here to help us track what client language and version created assets.

Expand Down

0 comments on commit b106724

Please sign in to comment.