Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR-37 pull termination clarification #234

Merged
merged 2 commits into from
Aug 4, 2023
Merged

ADR-37 pull termination clarification #234

merged 2 commits into from
Aug 4, 2023

Conversation

mtmk
Copy link
Contributor

@mtmk mtmk commented Aug 4, 2023

Explain the relationship between pull termination and returning from the call e.g. fetch()

Explain the relationship between pull termination and returning from the call e.g. fetch()
@mtmk mtmk requested a review from Jarema August 4, 2023 15:10
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

There is technically one more status that is not recoverable.

adr/ADR-37.md Outdated Show resolved Hide resolved
@mtmk mtmk requested a review from Jarema August 4, 2023 18:34
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jarema Jarema merged commit 8b055a5 into main Aug 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants