ADR-43: message ttl #292
Merged
ADR-43: message ttl #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
reviewed
Jul 11, 2024
ripienaar
commented
Jul 11, 2024
caspervonb
reviewed
Jul 11, 2024
aricart
reviewed
Jul 11, 2024
aricart
reviewed
Jul 11, 2024
ripienaar
commented
Jul 11, 2024
Signed-off-by: R.I.Pienaar <[email protected]>
Signed-off-by: R.I.Pienaar <[email protected]>
|
Have changed the wording around MaxAge rather as a admin control for resource management its stated as the default when not set on a message and also the maximum allowed except for the never expire ones. We can later restrict that with a config bool if we want but I dont want to add 3 new stream configs right at the start if it can be avoided or later end up not being needed I'll merge this one end of day baring other feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.