Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various Ruby warnings #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zarqman
Copy link

@zarqman zarqman commented Aug 9, 2024

This PR fixes a bunch of ruby warnings. There are no changes in behavior. Tested on Ruby 3.3.

gems/nats-pure/lib/nats/io/jetstream.rb:14: warning: gems/nats-pure/lib/nats/io/jetstream.rb:14: warning: loading in progress, circular require considered harmful - gems/nats-pure/lib/nats/io/msg.rb
gems/nats-pure/lib/nats/io/jetstream.rb:15: warning: gems/nats-pure/lib/nats/io/jetstream.rb:15: warning: loading in progress, circular require considered harmful - gems/nats-pure/lib/nats/io/client.rb
gems/nats-pure/lib/nats/io/client.rb:623: warning: assigned but unused variable - msg_size
gems/nats-pure/lib/nats/io/client.rb:934: warning: assigned but unused variable - err
gems/nats-pure/lib/nats/io/client.rb:1181: warning: assigned but unused variable - sid
gems/nats-pure/lib/nats/io/client.rb:1818: warning: assigned but unused variable - opts
gems/nats-pure/lib/nats/io/subscription.rb:75: warning: method redefined; discarding old concurrency_semaphore
gems/nats-pure/lib/nats/io/client.rb:758: warning: method redefined; discarding old connected_server

tested on ruby 3.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant