Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Build with GitHub actions #748

Merged
merged 6 commits into from
Apr 26, 2024
Merged

[ADDED] Build with GitHub actions #748

merged 6 commits into from
Apr 26, 2024

Conversation

levb
Copy link
Collaborator

@levb levb commented Apr 23, 2024

  • For all PR events: all tests with gcc and clang, coverage, all sanitize modes, in Debug mode against main
  • For all push events (including in PRs) all tests with gcc and clang, in Release mode, against main
  • For pushes to main, release_* check against the latest server release, v2.9.11; older C compilers, TLS OFF, Streaming OFF
  • Also added backtrace in tests on linux

Coverage checks should work for new PRs once this is merged to main and ran there.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@8099b5c). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #748   +/-   ##
=======================================
  Coverage        ?   68.76%           
=======================================
  Files           ?       38           
  Lines           ?    15100           
  Branches        ?     3119           
=======================================
  Hits            ?    10384           
  Misses          ?     1680           
  Partials        ?     3036           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levb levb requested review from mtmk and Jarema April 23, 2024 16:30
@levb levb changed the title WIP: [ADDED] build with GitHub actions [ADDED] Build with GitHub actions Apr 23, 2024
@levb levb marked this pull request as ready for review April 23, 2024 16:43
Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb requested a review from kozlovic April 25, 2024 12:56
@levb
Copy link
Collaborator Author

levb commented Apr 25, 2024

@kozlovic Can you please also review? I'll run it in parallel with Travis for a while. The "Release" build can be tested on your own branch if you remove the branch: main,... from on-push-release.yml

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it is required, I would comment the verbose flag from CMakeLists.txt and maybe change the size_t to int (unless you have some doc that shows that it ought to be a size_t.

CMakeLists.txt Outdated Show resolved Hide resolved
test/test.c Show resolved Hide resolved
@levb levb requested a review from kozlovic April 26, 2024 11:38
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb merged commit 58a7e24 into main Apr 26, 2024
15 checks passed
@levb levb deleted the lev-new-GH-action branch April 26, 2024 17:33
@kozlovic
Copy link
Member

@levb By the way, I forgot to comment at the time, but some of the matrix tests are run 3 times, is it intentional or was it part of some debugging/test at the time you were writing the PR? There is nothing wrong running each test 3 times in a row, it may catch some issues that are timing based, but just wanted to make sure it was intentional.

@levb
Copy link
Collaborator Author

levb commented Apr 29, 2024

Intentional, so see the flappers more often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants