feat: add pause consumer #1234
Draft
feat: add pause consumer #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
yordis
force-pushed
the
fixes-1218
branch
2 times, most recently
from
62e2703
to
e054054
Compare
|
Thanks for the PR! However, this feature has to be implemented in async-nats. Let me know if I can help you with that in any way, or reach me on NATS slack, if you want to continue the work on this of course :). |
yordis
force-pushed
the
fixes-1218
branch
6 times, most recently
from
cda3184
to
931536f
Compare
Signed-off-by: Yordis Prieto <[email protected]>
|
Am I going in the right direction now? |
Jarema
requested changes
May 20, 2024
| @@ -850,6 +850,64 @@ impl Stream { | |||
| } | |||
| } | |||
|
|
|||
| /// Pause a [Consumer] until the given time. | |||
There was a problem hiding this comment.
I would add a note about what it means, briefly.
|
|
||
| async fn request_pause_consumer(&self, name: &str, pause_until: Option<OffsetDateTime>) -> Result<PauseResponse, ConsumerError> { | ||
| let subject = format!("CONSUMER.PAUSE.{}.{}", self.info.config.name, name); | ||
| let payload = &PauseConsumerRequest{ pause_until }; |
There was a problem hiding this comment.
I would use literal json! as the struct is used only once.
| @@ -3475,6 +3475,7 @@ mod jetstream { | |||
| max_ack_pending: 150, | |||
| }), | |||
| first_sequence: Some(505), | |||
| pause_until: None, | |||
There was a problem hiding this comment.
We need to add test for pause/unpause.
I'm happy to help with that.
|
@yordis hey! Are you interested in finishing the PR? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1218