Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend header nav to exclude frontCover pages #3984

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Extend header nav to exclude frontCover pages #3984

wants to merge 2 commits into from

Conversation

G-Ambatte
Copy link
Collaborator

A small extension to the header nav generation function to add frontCover pages to the list of page types that are excluded from header/ID detection, and creates a basic framework for similar future extensions.

@G-Ambatte G-Ambatte added P3 - low priority Obscure tweak or fix for a single user 🔍 R0 - Needs first review 👀 PR ready but has not been reviewed labels Jan 13, 2025
@G-Ambatte G-Ambatte self-assigned this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbolack-ab dbolack-ab dbolack-ab approved these changes

@5e-Cleric 5e-Cleric Awaiting requested review from 5e-Cleric

@calculuschild calculuschild Awaiting requested review from calculuschild

At least 2 approving reviews are required to merge this pull request.

Assignees

@G-Ambatte G-Ambatte

Labels
P3 - low priority Obscure tweak or fix for a single user 🔍 R0 - Needs first review 👀 PR ready but has not been reviewed
Projects
@calculuschild's backlog
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@G-Ambatte @dbolack-ab @calculuschild