Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mysql CI #246

Closed
wants to merge 6 commits into from
Closed

Fix Mysql CI #246

wants to merge 6 commits into from

Conversation

chadell
Copy link
Contributor

@chadell chadell commented May 27, 2024

No description provided.

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs the changelog snippet.

@chadell
Copy link
Contributor Author

chadell commented May 28, 2024

LGTM, just needs the changelog snippet.

@jdrew82 , do you know why MySQL tests are not included in the CI???

@jdrew82
Copy link
Contributor

jdrew82 commented May 28, 2024

LGTM, just needs the changelog snippet.

@jdrew82 , do you know why MySQL tests are not included in the CI???

I believe this was something related to the IPRange class which might not be relevant any longer. Can't hurt to enable them in CI and see.

@chadell
Copy link
Contributor Author

chadell commented Jun 6, 2024

LGTM, just needs the changelog snippet.

@jdrew82 , do you know why MySQL tests are not included in the CI???

I believe this was something related to the IPRange class which might not be relevant any longer. Can't hurt to enable them in CI and see.

MySQLdb.OperationalError: (1553, "Cannot drop index 'unique_with_index': needed in a foreign key constraint") -> still there.

@jdrew82
Copy link
Contributor

jdrew82 commented Jun 6, 2024

LGTM, just needs the changelog snippet.

@jdrew82 , do you know why MySQL tests are not included in the CI???

I believe this was something related to the IPRange class which might not be relevant any longer. Can't hurt to enable them in CI and see.

MySQLdb.OperationalError: (1553, "Cannot drop index 'unique_with_index': needed in a foreign key constraint") -> still there.

Well that answers that then! Guess we need to leave MySQL support off for now until we figure out a solution.

@jdrew82
Copy link
Contributor

jdrew82 commented Jul 17, 2024

@chadell any reason we shouldn't just close this and delete the branch?

@chadell
Copy link
Contributor Author

chadell commented Jul 22, 2024

let's close it

@chadell chadell closed this Jul 22, 2024
@chadell chadell deleted the mysql-ci-fix branch July 22, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants