-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #677]: Add accessibility checks against pr preview env #84
Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 93.1% | 81/87 |
🟢 | Branches | 82.35% | 14/17 |
🟢 | Functions | 93.33% | 14/15 |
🟢 | Lines | 93.59% | 73/78 |
Test suite run success
16 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from af8e2bd
f7f6f50
to
abd3dc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at this comment on the e2e PR. I'd think that we'd want to do something similar here in order to support multiple apps and in order to be able to support running the accessibility scans outside the context of a PR environment. In other words, I think we'll want to have this workflow take an app_name
input in addition to a service_endpoint
input, then use that to load app-specific configurations (since different apps will have different sets of URLs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a quick if/else statement in the workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
I think we can close this but keep it as a reference - we moved to e2e playwright a11y instead for the platform : #85 |
We ended up using a11y checks in playwright rather than shipping a separate (pa11y) dependency for it - see the e2e PR on the Closing this |
Ticket
Resolves #677
Changes
Run of accessibility job:
Preview environment