Containerize e2e tests #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lorenyu just checking in on general format of this before going further - a summary so far:
|
lorenyu
reviewed
Oct 22, 2024
doshitan
reviewed
Oct 28, 2024
lorenyu
reviewed
Oct 28, 2024
Co-authored-by: Tanner Doshier <[email protected]>
Co-authored-by: Loren Yu <[email protected]>
|
I think we're close to being able to move this to |
lorenyu
approved these changes
Oct 29, 2024
rylew1
added a commit
to navapbc/template-infra
that referenced
this pull request
Oct 30, 2024
## Ticket #735 ## Changes - dockerize e2e tests with playwright - Tested on `platform-test-nextjs` => navapbc/platform-test-nextjs#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
navapbc/template-infra#735
Changes
Context
Imrproves portability and avoids having to
apt-geta bunch of packages https://github.com/navapbc/template-infra/blob/32ce571bd5656c4efc0615c58b2e8ed2a3a739f8/Makefile#L235For all local e2e testing - you'll need to have the app running locally and call the run command with the correct port and app (folder name) (hitting your locally running app from local docker uses a base url of
host.docker.internal)PR checks are still testing against the PR preview env
Opened on a
template-infra=> navapbc/template-infra#770https://playwright.dev/docs/docker
output.mov
Preview environment