Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semver vulnerability in base image #175

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Fix semver vulnerability in base image #175

merged 3 commits into from
Jul 13, 2023

Conversation

lorenyu
Copy link
Contributor

@lorenyu lorenyu commented Jul 13, 2023

Ticket

n/a

Changes

  • Fix semver vulnerability in base image by removing npm from release stage,
    since the version of npm in the base image had a vulnerability in the semver
    dependency
  • Target release stage explicitly in make release-build

Context for reviewers

Tackling the stubborn last vulnerability in the anchor scan

Testing

Made the changes in platform-test-nextjs repo in this PR: navapbc/platform-test-nextjs#79

  • You can see that the scans all pass!
  • Also triggered e2e tests to show that the service still works

@lorenyu lorenyu requested review from sawyerh and Nava-JoshLong and removed request for sawyerh July 13, 2023 17:06
app/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Sawyer Hollenshead <[email protected]>
@lorenyu lorenyu merged commit 7778fc8 into main Jul 13, 2023
6 checks passed
@lorenyu lorenyu deleted the lorenyu/tmptestanchor branch July 13, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants