Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: Clearer script calls #574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

doshitan
Copy link
Contributor

Recommend avoiding backticks to indicate command substitution in general and to
standardize on $(). This can be a little confusing in a makefile which also
uses $() to indicate its own calls, but the consistency is better in my
opinion. So swap those where used.

Also, Make isn't Bash, so use explicit shell function to highlight what is
intended to be executed by Make.

Though CURRENT_ACCOUNT_ALIAS and CURRENT_ACCOUNT_ID also don't appear to be
used currently, so could also be dropped.

Copy link
Contributor

@rocketnova rocketnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your make expertise here.

What do you think is the best way to maintain these guidelines going forward? Different options I can think of, but that I am not tied to:

  • Add a comment about these at the top of the file
  • Add a Makefile styleguide to /docs
  • Add a Makefile linter (does this exist / do you know any?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants