FAGSYSTEM-327210: Tar ikke med frilansandel lagt til senere enn fakta… #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espenjv
reviewed
Apr 22, 2024
| @@ -94,7 +95,8 @@ private void lagFrilansDel(BeregningsgrunnlagDto beregningsgrunnlag, | |||
| Optional<FaktaAktørDto> faktaAktør) { | |||
| vurderMottarYtelseDto.setErFrilans(VurderMottarYtelseTjeneste.erFrilanser(beregningsgrunnlag)); | |||
| beregningsgrunnlag.getBeregningsgrunnlagPerioder().get(0).getBeregningsgrunnlagPrStatusOgAndelList().stream() | |||
| .filter(andel -> andel.getAktivitetStatus().erFrilanser()).findFirst() | |||
| .filter(andel -> andel.getAktivitetStatus().erFrilanser() | |||
| && (AndelKilde.PROSESS_START.equals(andel.getKilde()) || AndelKilde.SAKSBEHANDLER_KOFAKBER.equals(andel.getKilde()))).findFirst() | |||
There was a problem hiding this comment.
Litt usikker på om det er riktig å ta med dei med kilde SAKSBEHANDLER_KOFAKBER her., men trur ikkje det speler så stor rolle for oss akkurat no.
There was a problem hiding this comment.
Ok, jeg tok de med siden jeg så at AndelerForFaktaOmBeregningTjeneste(Linje 39) tok de med, men det er kanskje unødvendig der også?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… om beregning