Ignorer overflødige skjemafelt #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjerga
commented
Dec 13, 2024
Comment on lines
-42
to
+44
| val mockRedis = MockRedis(RedisPrefix.Innsending) | ||
| val mockRedisStore = mockk<RedisStore>(relaxed = true) |
There was a problem hiding this comment.
MockRedis er en mer avansert mock som må brukes i testene til de statefulle servicene. Endrer til en enkel mock her og i testene for flere andre stateless servicer.
bjerga
commented
Dec 13, 2024
| fun `skal ikke lagre duplikat inntektsmelding`() { | ||
| fun `skal ikke lagre duplikat inntektsmeldingskjema`() { |
There was a problem hiding this comment.
Disse to testene var kliss like, så jeg fjernet den ene.
This reverts commit 4d96778.
|
Testet OK. |
magnusae
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
De mest interessante endringene er i
InntektsmeldingUtils.kt.Når vi utfører duplikatsjekk på innsendt skjema så bør vi ignorere felter som Spleis ikke har bedt om. Det fordi disse feltene vil bli vasket bort senere i løypa. Dvs. at når Spleis ikke har bedt om inntekt, så vil to skjema med ulik inntekt vil være helt like når vi sender dem til Spleis. Da bør vi behandle de to skjemaene som duplikater.
Merk at dette er en løsning på at frontend sender backend felter som er overflødige. Den endelige løsningen bør være at frontend ikke sender disse feltene, men det vil ta tid (og en designer) å løse.