Mer beskrivende dokument tittel i dokarkiv #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Venter på at devmiljø fikses for å teste funksjonalitet. |
bjerga
reviewed
Jan 16, 2025
apps/joark/src/main/kotlin/no/nav/helsearbeidsgiver/inntektsmelding/joark/JournalfoerImRiver.kt
Outdated
Show resolved
Hide resolved
apps/joark/src/main/kotlin/no/nav/helsearbeidsgiver/inntektsmelding/joark/JournalfoerImRiver.kt
Outdated
Show resolved
Hide resolved
apps/joark/src/main/kotlin/no/nav/helsearbeidsgiver/inntektsmelding/joark/JournalfoerImRiver.kt
Outdated
Show resolved
Hide resolved
apps/joark/src/main/kotlin/no/nav/helsearbeidsgiver/inntektsmelding/joark/JournalfoerImRiver.kt
Outdated
Show resolved
Hide resolved
...ark/src/test/kotlin/no/nav/helsearbeidsgiver/inntektsmelding/joark/JournalfoerImRiverTest.kt
Outdated
Show resolved
Hide resolved
...ark/src/test/kotlin/no/nav/helsearbeidsgiver/inntektsmelding/joark/JournalfoerImRiverTest.kt
Outdated
Show resolved
Hide resolved
Jesper-Hustad
changed the title
|
Ser ikke endring i dev miljø, tester annen tittel i joark tilDokumenter |
|
|
bjerga
reviewed
Jan 16, 2025
...ark/src/test/kotlin/no/nav/helsearbeidsgiver/inntektsmelding/joark/JournalfoerImRiverTest.kt
Outdated
Show resolved
Hide resolved
apps/felles/src/main/kotlin/no/nav/helsearbeidsgiver/felles/utils/PeriodeUtils.kt
Outdated
Show resolved
Hide resolved
bjerga
approved these changes
Jan 16, 2025
|
Fikk |
Jesper-Hustad
commented
Jan 17, 2025
| @@ -49,7 +49,7 @@ fun tilDokumenter( | |||
|
|
|||
| private fun ByteArray.encode(): String = base64.encodeToString(this) | |||
|
|
|||
| fun Inntektsmelding.tilJournalTittel(): String { | |||
| fun Inntektsmelding.tilDokumentbeskrivelse(): String { | |||
There was a problem hiding this comment.
Byttet til Dokumentberskrivelse da dette er navnet på feltet i gosys
bjerga
approved these changes
Jan 17, 2025
Comment on lines
26
to
27
| fun mockInntekstmeldingMedPerioder(perioder: List<Periode>): Inntektsmelding = | ||
| mockInntektsmeldingV1().copy(agp = mockInntektsmeldingV1().agp?.copy(perioder = perioder)) |
There was a problem hiding this comment.
Ville gjort denne private og flyttet den nederst i fila. Forventer ikke en mock-funksjon midt mellom testene.
| mockInntektsmeldingV1().copy(agp = mockInntektsmeldingV1().agp?.copy(perioder = perioder)) | ||
|
|
||
| @Test | ||
| fun journalTittelToPerioder() { |
There was a problem hiding this comment.
Denne og følgende tester bør vel bytte ut "journaltittel" med "dokumentbeskrivelse"?
b162214
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endret på beskrivende tittel til PDF lagret i dokarkiv (ikke filnavnet).
Før:
InntektsmeldingEtter:
Inntektsmelding-914337658-05.10.2018 - [...] - 22.10.2018Formatet inkluderer nå orgnr - f.o.m - t.o.m.