tillat nullable verdier i MDC #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uten å vite hvilke uuid-er som er satt / tilgjengelig
bjerga
reviewed
Dec 15, 2023
Comment on lines
+179
to
+185
| MdcUtils.withLogFields( | ||
| "empty" to null, | ||
| "non-empty" to "not null" | ||
| ) { | ||
| MDC.get("empty") shouldBe null | ||
| MDC.get("non-empty") shouldBe "not null" | ||
| } |
There was a problem hiding this comment.
Har du testet at de ikke logges? Jeg har opplevd at noen Java-klasser oppfører seg forskjellig med når null er eksplisitt satt i motsetning til å aldri bli satt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gjør det enklere for applikasjoner å logge uten å vite hvilke uuid-er som er satt / tilgjengelig