Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorisere/nedprioritere enkelte kodeverksverdier #1777

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

baskevold
Copy link
Contributor

No description provided.

@baskevold baskevold changed the title Skjule nedprioritere kodeverksverdier Favorisere/nedprioritere enkelte kodeverksverdier Dec 1, 2023
@baskevold baskevold marked this pull request as ready for review December 4, 2023 07:40
@baskevold baskevold requested a review from a team as a code owner December 4, 2023 07:41
@baskevold baskevold requested a review from boerta December 4, 2023 07:41
# Conflicts:
#	src/main/kotlin/no/nav/k9/los/nyoppgavestyring/mottak/feltdefinisjon/FeltdefinisjonRepository.kt
#	src/main/kotlin/no/nav/k9/los/nyoppgavestyring/query/db/OppgaveQueryRepository.kt
@@ -2,6 +2,7 @@ package no.nav.k9.los.nyoppgavestyring.query.dto.felter

class Verdiforklaring(
val verdi: String,
val visningsnavn: String
val visningsnavn: String,
val sekundærvalg: Boolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ønsker meg en forklarende kommentar på dette feltet, kanskje? Hvordan blir det at noe ikke er en favoritt til et sekundært valg? Hva er et sekundært valg for noe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det er mindre brukte kodeverksverdier. Dette tilsvarer "avansert" og knyttet til visningen - der sekundærvalg vises separat nederst i dropdown. Det virket litt feil å lagre det som sekundærvalg i db, men er er åpen for forslag

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, første refleks er at "mindreBrukt" i så fall er en forbedring

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evt "sorterTilSlutt"/"sorterNederst"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hvorfor trenger vi en inversform i verdiforklaring? Kan det ikke bare være "favoritt" her også?

@baskevold baskevold merged commit b85e728 into master Dec 5, 2023
1 check passed
@baskevold baskevold deleted the skjule-nedprioritere-kodeverksverdier branch December 5, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants