Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kontaktinfo #1703

Merged
merged 19 commits into from
Oct 13, 2023
Merged

Kontaktinfo #1703

merged 19 commits into from
Oct 13, 2023

Conversation

ebelegu
Copy link
Contributor

@ebelegu ebelegu commented Oct 10, 2023

No description provided.

@ebelegu
Fjernet fakedings for lokal
7d66ce1
@ebelegu
Kontaktinfo
d554e92
@ebelegu
la til kontaktinfo-mock i server
ae172a3
@ebelegu
Update kontaktinfoApiMock.js
9b61125
@ebelegu
Lagt inn kontaktinfo-komponentene..
90c6cde 
Lagt inn kontaktinfo-komponentene og omstrukturert litt for å få samme design som i skissene for panelene.
@ebelegu ebelegu requested a review from a team as a code owner October 10, 2023 15:28
@peterbb
Copy link
Contributor

peterbb commented Oct 10, 2023

Siden useSWR automatisk dedupliserer like kall (= kall med samme keys) i løpet av 2 sekunder, så trenger vi ikke å kalle useKontaktinfo så høyt oppe i treet for så å sende det nedover som props. Vi kan putte kallet heeelt neders i treet hvor vi faktisk trenger informasjonen, i både KontaktinfoUnderenhet og KontaktinfoHovedenhet.

@peterbb
Copy link
Contributor

peterbb commented Oct 13, 2023

Testet OK i dev gitt navikt/min-side-arbeidsgiver-api#335

@peterbb peterbb merged commit b196260 into master Oct 13, 2023
@peterbb peterbb deleted the Kontaktinfo branch October 13, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbb peterbb peterbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebelegu @peterbb