Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ny brødsmulesti #1890

Merged
merged 5 commits into from
Nov 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/Pages/Artikkel/Artikkel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,7 @@ export const Artikkel = () => {

return (
<>
<Brodsmulesti
brodsmuler={[
{
url: `/artikkel/${id}`,
title: tittel,
handleInApp: true,
},
]}
/>
<Brodsmulesti/>
<ArtikkelBanner tittel={tittel} />
<div
className={'artikkel-container'}
Expand Down
13 changes: 13 additions & 0 deletions src/Pages/Banner.css
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,17 @@

.banner__saksoversikt__tittel {
grid-area: tittel;
}

.brodsmulesti {
display: flex;
background: var(--a-bg-default);
padding: 16px 32px;
font-size: 1.125rem;
align-items: center;
}
.brodsmulesti svg {
color: var(--a-text-default);
width: 32px;
height: 32px;
}
65 changes: 17 additions & 48 deletions src/Pages/Banner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@ import { OrganisasjonsDetaljerContext } from './OrganisasjonDetaljerProvider';
import { OrganisasjonerOgTilgangerContext } from './OrganisasjonerOgTilgangerProvider';
import * as Record from '../utils/Record';
import { NotifikasjonWidget } from '@navikt/arbeidsgiver-notifikasjon-widget';
import { useNavigate, useSearchParams } from 'react-router-dom';
import { onBreadcrumbClick, setBreadcrumbs } from '@navikt/nav-dekoratoren-moduler';
import { useSearchParams } from 'react-router-dom';
import { Heading, Loader } from '@navikt/ds-react';
import './Banner.css';
import { LenkeMedLogging } from '../GeneriskeElementer/LenkeMedLogging';
import { HouseIcon } from '@navikt/aksel-icons';

interface OwnProps {
sidetittel?: string;
Expand All @@ -17,19 +18,7 @@ interface OwnProps {
export const SimpleBanner: FunctionComponent<OwnProps> = ({
sidetittel = 'Min side – arbeidsgiver',
}) => {
useEffect(() => {
setBreadcrumbs([
{
url: 'https://arbeidsgiver.nav.no/min-side-arbeidsgiver',
title: 'Min side – arbeidsgiver',
},
]).then(() => {});
}, []);
return (
<Bedriftsmeny
sidetittel={'Min side – arbeidsgiver'}
/>
);
return <Bedriftsmeny sidetittel={'Min side – arbeidsgiver'} />;
};

export const SaksoversiktBanner = () => (
Expand Down Expand Up @@ -77,44 +66,24 @@ export const BannerMedBedriftsmeny: FunctionComponent<OwnProps> = ({ sidetittel
: [];

return (
<Bedriftsmeny
sidetittel={sidetittel}
organisasjoner={orgs}
orgnrSearchParam={useOrgnrHook}
>
<Bedriftsmeny sidetittel={sidetittel} organisasjoner={orgs} orgnrSearchParam={useOrgnrHook}>
<NotifikasjonWidget />
</Bedriftsmeny>
);
};

interface Brodsmule {
url: string;
title: string;
handleInApp: boolean;
}

interface BrodsmuleProps {
brodsmuler: Brodsmule[];
}

export const Brodsmulesti = ({ brodsmuler }: BrodsmuleProps) => {
const navigate = useNavigate();

onBreadcrumbClick((breadcrumb) => {
navigate(breadcrumb.url);
});

const defaultBrodsmule: Brodsmule[] = [
{ url: '/', title: 'Min side – arbeidsgiver', handleInApp: true },
];

const breadcrumbs = defaultBrodsmule.concat(brodsmuler);

useEffect(() => {
setBreadcrumbs(breadcrumbs);
}, [JSON.stringify(brodsmuler)]);

return <></>;
export const Brodsmulesti = () => {
return (
<div className="brodsmulesti">
<LenkeMedLogging
loggLenketekst={`Brødsmulesti - Min side - arbeidsgiver`}
href={__BASE_PATH__}
>
<HouseIcon title="a11y-title" fontSize="1.5rem" />
Min side – arbeidsgiver
</LenkeMedLogging>
</div>
);
};

export const Spinner = () => (
Expand Down
1 change: 0 additions & 1 deletion src/Pages/Hovedside/Hovedside.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ const Hovedside: FunctionComponent = () => {

return (
<div>
<Brodsmulesti brodsmuler={[]} />
<div className="hovedside-container">
<AdvarselBannerTestversjon />
<Alerts />
Expand Down
6 changes: 0 additions & 6 deletions src/Pages/OmVirksomheten/OmVirksomheten.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import Underenhet from './Underenhet';
import OverordnetEnhet from './OverordnetEnhet';
import './OmVirksomheten.css';
import { Box } from '@navikt/ds-react';
import { Brodsmulesti } from '../Banner';

const Kontaktpanel = ({ children }: { children: React.ReactNode }) => (
<Box className="informasjon-om-bedrift">{children}</Box>
Expand All @@ -21,11 +20,6 @@ const OmVirksomheten: FunctionComponent = () => {

return (
<>
<Brodsmulesti
brodsmuler={[
{ url: '/bedriftsinformasjon', title: 'Om virksomheten', handleInApp: true },
]}
/>
{overordnetenhet !== undefined && underenhet !== undefined ? (
<>
<Kontaktpanel>
Expand Down
36 changes: 12 additions & 24 deletions src/Pages/Pages.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ const Pages: FunctionComponent = () => (
path="/bedriftsinformasjon"
element={
<>
<Brodsmulesti/>
<BannerMedBedriftsmeny
sidetittel={'Om virksomheten'}
/>
Expand All @@ -85,16 +86,8 @@ const Pages: FunctionComponent = () => (
path="/saksoversikt"
element={
<>
<Brodsmulesti/>
<SaksoversiktBanner />
<Brodsmulesti
brodsmuler={[
{
url: '/saksoversikt',
title: 'Saksoversikt',
handleInApp: true,
},
]}
/>
<Saksoversikt />
</>
}
Expand All @@ -103,21 +96,8 @@ const Pages: FunctionComponent = () => (
path="/sak"
element={
<>
<Brodsmulesti/>
<SaksoversiktBanner />
<Brodsmulesti
brodsmuler={[
{
url: '/saksoversikt',
title: 'Saksoversikt',
handleInApp: true,
},
{
url: '/sak',
title: 'Sak',
handleInApp: true,
},
]}
/>
<Saksside />
</>
}
Expand All @@ -128,7 +108,15 @@ const Pages: FunctionComponent = () => (
<Navigate to="/saksoversikt" replace={true} />
}
/>
<Route path="/artikkel/:id" element={<Artikkel />} />
<Route
path="/artikkel/:id"
element={
<>
<Brodsmulesti/>
<Artikkel />
</>
}
/>
<Route
path="*"
element={
Expand Down
13 changes: 13 additions & 0 deletions src/mocks/brukerApi/resolvers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,16 @@ export const sakstyperResolver = (sakstyper: Merkelapp[]) =>

return HttpResponse.json({ errors, data });
});

export const hentSakByIdResolver = (saker: Sak[]) =>
graphql.query('HENT_SAK_ID', async ({ query, variables }) => {
const sak = saker[0];
return HttpResponse.json({
data: {
sakById: {
sak,
feilAltinn: false,
},
}
});
} );
2 changes: 2 additions & 0 deletions src/mocks/handlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
hentNotifikasjonerResolver,
hentSakerResolver,
sakstyperResolver,
hentSakByIdResolver,
} from './brukerApi/resolvers';

/**
Expand Down Expand Up @@ -220,4 +221,5 @@ export const handlers = [
hentKalenderavtalerResolver([]),
hentNotifikasjonerResolver([]),
sakstyperResolver([]),
hentSakByIdResolver([])
];
2 changes: 2 additions & 0 deletions src/mocks/scenarios/dagligLederScenario.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
hentNotifikasjonerResolver,
hentSakerResolver,
sakstyperResolver,
hentSakByIdResolver,
} from '../brukerApi/resolvers';
import { alleSaker } from '../brukerApi/alleSaker';
import { alleKalenderavtaler } from '../brukerApi/alleKalenderavtaler';
Expand Down Expand Up @@ -146,4 +147,5 @@ export const dagligLederScenario = [
sakstyperResolver(alleSaker.map(({ merkelapp }) => merkelapp as Merkelapp)),
hentKalenderavtalerResolver(alleKalenderavtaler),
hentNotifikasjonerResolver(alleNotifikasjoner),
hentSakByIdResolver(alleSaker),
];
3 changes: 2 additions & 1 deletion src/mocks/scenarios/nærmesteLederScenario.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { faker } from '@faker-js/faker';
import { fromEntries } from '../../utils/Record';
import {
hentKalenderavtalerResolver,
hentNotifikasjonerResolver,
hentNotifikasjonerResolver, hentSakByIdResolver,
hentSakerResolver,
sakstyperResolver,
} from '../brukerApi/resolvers';
Expand Down Expand Up @@ -69,4 +69,5 @@ export const nærmesteLederScenario = [
sakstyperResolver(nærmesteLederSaker.map(({ merkelapp }) => merkelapp as Merkelapp)),
hentNotifikasjonerResolver(nærmesteLederNotifikasjoner),
hentKalenderavtalerResolver(nærmesteLederKalenderavtaler),
hentSakByIdResolver(nærmesteLederSaker),
];
3 changes: 2 additions & 1 deletion src/mocks/scenarios/regnskapsforerScenario.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { alleSaker } from '../brukerApi/alleSaker';
import { Merkelapp } from '../brukerApi/alleMerkelapper';
import {
hentKalenderavtalerResolver,
hentNotifikasjonerResolver,
hentNotifikasjonerResolver, hentSakByIdResolver,
hentSakerResolver,
sakstyperResolver,
} from '../brukerApi/resolvers';
Expand Down Expand Up @@ -82,4 +82,5 @@ export const regnskapsforerScenario = [
sakstyperResolver(regnskapsførerSaker.map(({ merkelapp }) => merkelapp as Merkelapp)),
hentKalenderavtalerResolver(regnskapsførerKalenderavtaler),
hentNotifikasjonerResolver(regnskapsførerNotifikasjoner),
hentSakByIdResolver(regnskapsførerSaker),
];
Loading