OKEnvelope can be three or four elements.

[mattn]

No description provided.

[sweep-ai]

Apply Sweep Rules to your PR?

• Apply: All new business logic should have corresponding unit tests.
• Apply: Refactor large functions to be more modular.

[fiatjaf]

Can it? I think it should be always 4. The NIP implies it's 4, then I checked Nostream, nostr-rs-relay and strfry and they all return an empty string with an ok-true message. Also https://github.com/mikedilger/gossip errors when it sees an OK message with 3 (it errored against my https://pyramid.fiatjaf.com/ relay).

Is this breaking something for you?

I think it is much simpler if we stick to 4. Less cases to check against. And maybe rephrase the NIP to clarify that it must always be 4?

[mattn]

TestOKEnvelopeEncodingAndDecoding tests it.

go-nostr/envelopes_test.go

Lines 67 to 71 in f8fb9e8

	func TestOKEnvelopeEncodingAndDecoding(t *testing.T) {
	okEnvelopes := []string{
	`["OK","3bf0c63fcb93463407af97a5e5ee64fa883d107ef9e558472c4eb9aaaefaaaaa",false,"error: could not connect to the database"]`,
	`["OK","3bf0c63fcb93463407af97a5e5ee64fa883d107ef9e558472c4eb9aaaefaaaaa",true]`,
	}

[fiatjaf]

OK, then I'll fix that test. It was based on me reading the spec wrongly in the past. Thank you.

Also I've been running all the tests automatically before pushing for all subpackages, but forgot to run the tests on the top-level package.