Redirect to RackCAS/FakeCAS when server_url is nil #155
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs a warning when not in the test environment Update README to include note about FakeCAS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RackCAS's Fake CAS is automatically included by RackCAS in the Rails test environment and comes with a hardcoded /logout route. This change redirects to /logout when server_url is not set and logs a warning if Rails is not in test. I've chosen to log that warning even when Fake CAS is included outside test so there may an argument for testing for FakeCAS before logging the warning.
Also added a note to the README about FakeCAS.